Skip to content

Add monkeyocr as a library and enable download tracking #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 24, 2025
Merged

Add monkeyocr as a library and enable download tracking #1544

merged 5 commits into from
Jun 24, 2025

Conversation

@echo840
Copy link
Contributor

@echo840 echo840 commented Jun 20, 2025

This PR adds monkeyocr as a dedicated library: https://huggingface.co/echo840/MonkeyOCR

@echo840 echo840 changed the title monkeyocr Add monkeyocr as a library Jun 20, 2025
@echo840 echo840 changed the title Add monkeyocr as a library Add monkeyocr as a library and enable download tracking Jun 20, 2025
Vaibhavs10
Vaibhavs10 approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for opening a PR @echo840 - let's wait for more approval before we merge!

merveenoyan
merveenoyan approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks a lot!

@merveenoyan
Copy link
Contributor

merveenoyan commented Jun 23, 2025

@echo840 can you lint this branch if possible? 🙏🏻

@echo840
Copy link
Contributor Author

echo840 commented Jun 23, 2025 •
edited
Loading

Thank you. I will check it.

@echo840
Copy link
Contributor Author

echo840 commented Jun 24, 2025

Hello. I followed the PR submitted for "tencent-song-generation" and, through comparison, I found that the only possible issue might be that the prettyLabel in "monkeyocr" was not capitalized. I've now updated it—though I'm not sure if it will resolve the problem.

1351750738162_ pic

1361750738162_ pic

Vaibhavs10
Vaibhavs10 reviewed Jun 24, 2025
View reviewed changes
@Vaibhavs10 Vaibhavs10 merged commit 697bf84 into huggingface:main Jun 24, 2025
2 of 4 checks passed
@Vaibhavs10
Copy link
Member

Vaibhavs10 commented Jun 24, 2025

Apologies for pushing in your branch @echo840 - the linting error was due to the moneyocr key.

"monkeyocr" -> monkeyocr

The download counts should be up in a day or two - congrats on the brilliant release!

@echo840
Copy link
Contributor Author

echo840 commented Jun 24, 2025

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vaibhavs10 Vaibhavs10 Vaibhavs10 approved these changes

@merveenoyan merveenoyan merveenoyan approved these changes

@SBrandeis SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@Wauplin Wauplin Awaiting requested review from Wauplin Wauplin is a code owner

@julien-c julien-c Awaiting requested review from julien-c julien-c is a code owner

@pcuenca pcuenca Awaiting requested review from pcuenca pcuenca is a code owner

@ngxson ngxson Awaiting requested review from ngxson ngxson is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@echo840 @merveenoyan @Vaibhavs10